Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on julia 1.2 #372

Closed
davidanthoff opened this issue Jul 18, 2019 · 1 comment
Closed

Tests fail on julia 1.2 #372

davidanthoff opened this issue Jul 18, 2019 · 1 comment
Labels
bug
Milestone
v0.6.1

Comments

@davidanthoff
Copy link
Member

https://travis-ci.org/julia-vscode/LanguageServer.jl/jobs/560588597

Unclear to me what is going on there...
@davidanthoff davidanthoff added this to the v0.6.1 milestone Jul 18, 2019
@JeffBezanson
Copy link
Contributor

I think I figured this out. In SymbolServer, from_static_init.jl:158:

                elseif !(isempty(t.types) || Base.isvatuple(t)) || t.mutable
                        out.vals[String(n)] = structStore(string.(p),
                                                     collect(string.(fieldnames(t))),
                                                     string.(collect(t.types)),
                                                     read_methods(x),
                                                     _getdoc(x))

t.types is not always defined. Should use fieldtypes instead.

@ZacLN ZacLN closed this as completed Aug 5, 2019
@JeffBezanson JeffBezanson mentioned this issue Aug 12, 2019
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.6.1
Development

No branches or pull requests
3 participants
@JeffBezanson @davidanthoff @ZacLN