Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing input error for test/show.jl in julia repo #107

Closed
domluna opened this issue Nov 6, 2019 · 7 comments
Closed

Parsing input error for test/show.jl in julia repo #107

domluna opened this issue Nov 6, 2019 · 7 comments
Assignees
Labels

Comments

@domluna
Copy link

domluna commented Nov 6, 2019

While trying out formatting on the entire julia repo, I encountered a file, test/show.jl which CSTParser cannot parse.

The formatter checks if the input can be parsed before proceeding.

https://github.com/domluna/JuliaFormatter.jl/blob/577138b80e5f40a61e695e55c723a10492779b6d/src/JuliaFormatter.jl#L214-L215

julia> s = read("test/show.jl") |> String;
julia> x, ps = CSTParser.parse(CSTParser.ParseState(s), true);
julia> ps.errored
true

This is the only file in the entire julia repo where this occurs.

@davidanthoff davidanthoff added this to the v1.0.1 milestone Nov 7, 2019
@ZacLN
Copy link
Contributor

ZacLN commented Nov 27, 2019

Hi, I can't replicate this on my system probably meaning this is fixed on the meta branch to be merged soon. Will check back after merging

@domluna
Copy link
Author

domluna commented Nov 27, 2019

I should mention this was with a checkout of 1.3.0-rc4 but it looks like with the most recent version of the file and v1.0.0 it still errors.

@domluna
Copy link
Author

domluna commented Dec 2, 2019

still errors with v1.1.0

@ZacLN
Copy link
Contributor

ZacLN commented Dec 2, 2019

This is due to JuliaLang/julia#32408, I'm having a look

@davidanthoff davidanthoff modified the milestones: v1.0.1, v2.0.1 Dec 14, 2019
@ZacLN
Copy link
Contributor

ZacLN commented Dec 15, 2019

#118 is a WIP fix for this but it will require careful handling within StaticLint/LanguageServer. I'm tempted to leave this until the next LS release so I can think about this

@davidanthoff davidanthoff modified the milestones: v2.0.1, v2.0.2 Dec 15, 2019
@davidanthoff
Copy link
Member

Sounds good, I moved it to the next milestone!

@davidanthoff davidanthoff modified the milestones: Next, Current Dec 19, 2019
@ZacLN
Copy link
Contributor

ZacLN commented Jan 15, 2020

This is fixed on CSTParser#master, the next release should be pretty soon

@ZacLN ZacLN closed this as completed Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants