feat(agents-api): Add label lookup for inputs and outputs #906
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 9a3cfd0 in 41 seconds
More details
- Looked at
102lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/workflows/task_execution/__init__.py:140
- Draft comment:
Initializingprevious_labelsas an empty dictionary if not provided is consistent with the changes for label lookup. This logic is correct. - Reason this comment was not posted:
Confidence changes required:0%
Therunmethod inTaskExecutionWorkflowclass initializesprevious_labelsas an empty dictionary if not provided. This is consistent with the changes made to support label lookup for inputs and outputs. The logic seems correct here.
Workflow ID: wflow_iVQFZayAMbHKoGjo
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #791
Important
Add label lookup for inputs and outputs in agents API by updating
StepContextand workflow execution methods.labelsattribute toStepContextintasks.pyfor label lookup in inputs and outputs.prepare_for_stepintasks.pyto merge labels with inputs and outputs.runmethod in__init__.pyto handleprevious_labelsfor task execution.continue_as_childinhelpers.pyto acceptprevious_labelsparameter.This description was created by
for 9a3cfd0. It will automatically update as commits are pushed.