-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu Jammy support. #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I linked #94 issue and added Alvaro's changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I've made a suggestion in the inline comment.
syscalls: | ||
- action: allow | ||
names: | ||
- clone3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we already supports filebeat 7, could you please check if this syscall is also needed for filebeat-7.yaml
? You can test it by replacing the default value of install_sources
config option with "deb https://artifacts.elastic.co/packages/7.x/apt stable main"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to mention this in the description but I forgot. Filebeat 7 has this problem fixed in 7.15.2 so I don't think we need to explicitly configure it.
This LGTM, but i'm curious if you need https://github.com/juju-solutions/layer-filebeat/blob/master/metadata.yaml I presume that charmcraft and the pack/push procedure means you don't, but wanted to double check just in case it was an oversight. |
@kwmonroe Thanks for the review. The series in |
Dependency: This change to
layer:beats-base
has to be merge as well for properUbuntu 22.04
support (more info in the PR).This change adds support for deployment of
filebeats
charm onUbuntu 22.04
and addscharmcraft.yaml
file for build compatibility withcharmcraft
.Two main changes were needed:
python3.10
(More info in PR linked above)clone3
syscall to list of allowed syscalls. Absence of this syscall caused an issues that are described in this Github Issue (It's fromapm
project, notfilebeats
but the problem and the solution are the same)Resolves #94