Add support for Amazon ECS services #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-sully
reviewed
Jul 14, 2023
jon-sully
reviewed
Jul 14, 2023
| it "initializes the config from default Amazon ECS ENV vars" do | ||
| # Users must set JUDOSCALE_URL manually when using Amazon ECS. | ||
| env = { | ||
| "ECS_CONTAINER_METADATA_URI" => "http://169.254.170.2/v3/a8880ee042bc4db3ba878dce65b769b6-2750272591", |
There was a problem hiding this comment.
Seems obvious but just want to make sure our bases are covered — the last value there is globally unique to separate tasks spun up under the same service umbrella?
There was a problem hiding this comment.
As far as I can tell, yes, but I'm not 100% sure. We don't actually use it for anything publicly available, though, so it's kind of arbitrary.
jon-sully
approved these changes
Jul 14, 2023
adamlogic
force-pushed
the
am-simplify-runtime-container
branch
from
be6aeda to
4563363
Compare
adamlogic
force-pushed
the
am-ecs-support
branch
from
4f3dc83 to
1ed681c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.