Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented test in respond to #15 #36

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

sami6mz
Copy link
Contributor

@sami6mz sami6mz commented Jul 7, 2023

Added a test to check whether the estimator is robut to (n,1) and (n,) inputs for t and y.

As for now :

DML_huber also return an error but it's because dim_x=1, this is already declared in #16.

Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is good as such, but it may point to other limitations of the codebase.

tests/estimation/test_get_estimation.py Show resolved Hide resolved
tests/estimation/test_get_estimation.py Outdated Show resolved Hide resolved
@sami6mz sami6mz changed the title Inplemented test in respond to #15 Implemented test in respond to #15 Jul 10, 2023
@judithabk6 judithabk6 merged commit 13c97da into judithabk6:main Jul 10, 2023
@sami6mz sami6mz deleted the tolerance_all4 branch July 28, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants