-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a documentation page #75
Comments
Yess please. There are parts in the current documentation page which seem slightly disconnected. For eg, in the [Add your model] (https://github.com/juanmc2005/StreamingSpeakerDiarization#add-your-model) section, as a first timer I do not understand how to run the code. Specifically because the code loads a "my_model.ckpt" file but I don't know how to create this file. It would be better if this model file could either be referenced in the repo under an "examples" folder or if its very huge, be downloadable for the demo code to run. |
Hi @amritbhat786, The "Add your model" section of the README is for custom models (think EEND or ECAPA-TDNN for example). The default pipeline uses pyannote/segmentation and pyannote/embedding automatically and you can run it with On the other hand I think the "Add your model" title is indeed a bit misleading, do you think it would be clearer if it was something like "Custom models"? |
Hi, thanks for the clarification. Yes, custom models sounds good to me. Also a comment stating that a file path should be specified in the example script would help as well. |
Thanks @amritbhat786 ! I'll make sure to make those changes for the next release. |
A first version of a documentation page is already in |
Problem
As the codebase grows, it is difficult for a user to keep track of all the features and mix-and-match possibilities available.
Idea
Create a documentation page with tutorials and an API reference.
The text was updated successfully, but these errors were encountered: