Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding to last chunk instead of ignoring it #49

Closed
juanmc2005 opened this issue May 8, 2022 · 1 comment
Closed

Add padding to last chunk instead of ignoring it #49

juanmc2005 opened this issue May 8, 2022 · 1 comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Version 0.3

Comments

@juanmc2005
Copy link
Owner

Problem

If the duration of the last chunk is lower than the desired duration, the chunk is ignored.

Idea

Pad the last (incomplete) chunk with zeros. This mainly affects FileAudioSource and AudioFileReader. It is important that num_chunks() (that estimates the number of chunks without actually doing the chunking) also counts this incomplete chunk.
@juanmc2005 juanmc2005 added feature New feature or request good first issue Good for newcomers labels May 8, 2022
@juanmc2005 juanmc2005 added this to the Version 0.4 milestone May 11, 2022
@juanmc2005 juanmc2005 added the help wanted Extra attention is needed label May 13, 2022
@juanmc2005 juanmc2005 mentioned this issue May 17, 2022
Merged
@juanmc2005 juanmc2005 modified the milestones: Version 0.4, Version 0.3 May 17, 2022
@juanmc2005
Copy link
Owner Author

Implemented in PR #55

@juanmc2005 juanmc2005 mentioned this issue May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
Version 0.3
Development

No branches or pull requests
1 participant
@juanmc2005