Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReDimNet embedding model #260

Open
rose-jinyang opened this issue Dec 19, 2024 · 1 comment
Open

Add ReDimNet embedding model #260

rose-jinyang opened this issue Dec 19, 2024 · 1 comment

Comments

@rose-jinyang
Copy link

rose-jinyang commented Dec 19, 2024

Hello
How are you?
Thanks for contributing to this project.
I am trying to add ReDimNet model (https://github.com/IDRnD/ReDimNet) as embedding model of piple-line.
But the ReDimNet model does not require weights parameter when getting embeddings from audio signal data.
How can I add this model?
Thanks

@juanmc2005
Copy link
Owner

Hi @rose-jinyang ! I love the idea of adding compatibility with new models! I would gladly merge a PR for this if you're up for it.
I suggest you take a look at how pyannote.audio implements weights for models such as WeSpeaker or SpeechBrain embeddings.
If I remember correctly, you can use the weights as a mask over the audio (one mask per speaker) and extract the embedding for each speaker from the masked audio. This will allow you to output one embedding per speaker by taking audio and weights as input.

Feel free to open a draft PR so I can guide you through it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants