Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker releases appear out of sync with the code releases? #253

Closed
mannp opened this issue Dec 7, 2021 · 19 comments · Fixed by #258
Closed

Docker releases appear out of sync with the code releases? #253

mannp opened this issue Dec 7, 2021 · 19 comments · Fixed by #258
Assignees
Labels
bug Something isn't working

Comments

@mannp
Copy link

mannp commented Dec 7, 2021

Issue description

The tags used for docker releases appear out of sync with the code releases?

0.12 was released a month ago according to docker, and it is not clear how they relate to the code releases?

Is there a docker release for 0.12.0-beta2, or I presume those other docker tags should be ignored?

To Reproduce

The docker releases I am referring to are these -> https://hub.docker.com/r/headscale/headscale/tags

Thanks for any clarification 👍🏻

@mannp mannp added the bug Something isn't working label Dec 7, 2021
@madhavajay
Copy link

Also, is it just me or did the latest tag just get deleted? This has been working for months and now im getting:

failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to create LLB definition: docker.io/headscale/headscale:latest: not found

@Akruidenberg
Copy link

I would like to test Openid. So version 0.12 with docker would be nice

@kradalby
Copy link
Collaborator

The docker release job is failing: https://github.com/juanfont/headscale/runs/4631424805?check_suite_focus=true

Could you have a look @ohdearaugustin ?

@ohdearaugustin
Copy link
Collaborator

I'm taking a look at it. It seems the PR with the changes to use a cache was not tested. For now it seems like the setup of the buildx environment was forgotten. I'm just testing out a fixed version and a PR will follow as soon as it works.

@Akruidenberg
Copy link

When will we see a new docker release?

@kradalby kradalby reopened this Dec 28, 2021
@kradalby
Copy link
Collaborator

We are missing ARM builds in the setup, I imagine that we will release a new version containing just docker builds as 0.12.2 when #259 is finished.

@ohdearaugustin
Copy link
Collaborator

The arm builds work with the #258, they are just slow. As qemu cross-compliation is not ideal.

@mannp
Copy link
Author

mannp commented Jan 6, 2022

Are amd64 builds available to get updated, while the arm builds are being worked on further?

@Akruidenberg
Copy link

Same question here. Would like to test the amd64 build soon

@kradalby
Copy link
Collaborator

kradalby commented Jan 6, 2022

@juanfont Can you try a -beta release to see if it works now and then release 0.12.2 to get things out?

@Akruidenberg
Copy link

No release yet?

@mannp
Copy link
Author

mannp commented Jan 11, 2022

Seems 0,12,2 beta 1 is out on dockerhub, thanks (amd64)

'latest' doesn't appear to work for me, it didn't update to beta 1 until I used the specific beta tag.

If it's fine for others, I'll close this issue.

@artemklevtsov
Copy link
Contributor

It would bi nice to add alpine based image (with appropriate tag on the Docker Hub). It will be much more convenient to manage container on the Synology Web UI for example.

@kradalby
Copy link
Collaborator

Why would alpine make it more manageable on synology?

@Akruidenberg
Copy link

Also, it takes less space and is more secure.

@artemklevtsov
Copy link
Contributor

artemklevtsov commented Jan 12, 2022

I can spawn the separate shell with ash and run commands from the Web UI.
изображение

@kradalby
Copy link
Collaborator

Also, it takes less space and is more secure.

We use distroless images, they are small and probably even more secure.

@kradalby
Copy link
Collaborator

I can spawn the separate shell with ash and run commands from the Web UI.

PRs are welcome, we dont plan to support alpine.

@mannp
Copy link
Author

mannp commented Jan 21, 2022

The original issue has been resolved, so I am closing this :)

@mannp mannp closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants