Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch sync group errors in integration tests #1459

Closed
kev-the-dev opened this issue May 11, 2023 · 2 comments
Closed

Catch sync group errors in integration tests #1459

kev-the-dev opened this issue May 11, 2023 · 2 comments
Labels
bug Something isn't working stale

Comments

@kev-the-dev
Copy link

Address TODOs like

headscale/integration/scenario.go

Line 299 in 252342a

// TODO(kradalby): error handle this
by using sync errgroup https://pkg.go.dev/golang.org/x/sync/errgroup#Group

(I am currently working on this)
@kev-the-dev kev-the-dev added the bug Something isn't working label May 11, 2023
@kev-the-dev kev-the-dev mentioned this issue May 11, 2023
Closed
5 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

This issue is stale because it has been open for 180 days with no activity.

@github-actions github-actions bot added the stale label Nov 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sync errorgroup handling in integration tests kev-the-dev/headscale
1 participant
@kev-the-dev