Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Linux) Lowering repeat delay breaks emergency force stop shortcut or applies without Kanata running. #1464

Open
2 tasks done
IndigoGollum opened this issue Jan 5, 2025 · 1 comment
Assignees
Labels
bug Something isn't working linux Issue pertains to Linux only PRs welcome jtroo has no plans to work on this at present, but PRs are welcome

Comments

@IndigoGollum
Copy link

IndigoGollum commented Jan 5, 2025

Requirements

Describe the bug

Setting the repeat delay in linux-x11-repeat-delay-rate in defcfg too low (in this case, i set it to 40,50 once and 300,50 later) stops the lctl-space-escape shortcut from stopping Kanata. I stopped the program after breaking it by increasing the delay in the config, loading the layout again, and then using the normal shortcut.

I tested this once after discovering it and in that test, Kanata said it closed but then the delay rate set in my config applied to my computer's default layout without Kanata running. I fixed this the same way as before.

Relevant kanata config

(defcfg
linux-x11-repeat-delay-rate 40,50
)

To Reproduce

1.Set the first number in linux-x11-repeat-delay-rate to something very low. Save the config then fix it and leave that change unsaved, so you can fix it without typing. Higher values below 400 are easier to recover from.
2.Load Kanata with this config file.
3.Try to close Kanata.

Expected behavior

Pressing left control + space + escape while Kanata is running should stop Kanata regardless of what's in my config.

Kanata version

1.7.0

Debug logs

No response

Operating system

Linux Mint MATE 22

Additional context

No response

@IndigoGollum IndigoGollum added the bug Something isn't working label Jan 5, 2025
@rszyma
Copy link
Contributor

rszyma commented Jan 5, 2025

I'm pretty sure this has nothing to do with control+space+escape not working, but rather linux-x11-repeat-delay-rate not being reverted upon exit.

looking at the implementation, we're simply calling xset r rate command, which is an external command that will not revert itself when kanata exits

@jtroo jtroo added linux Issue pertains to Linux only PRs welcome jtroo has no plans to work on this at present, but PRs are welcome labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working linux Issue pertains to Linux only PRs welcome jtroo has no plans to work on this at present, but PRs are welcome
Projects
None yet
Development

No branches or pull requests

3 participants