Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No missing-phase-hooks suggestion in buildPythonPackage #100

Open
rmcgibbo opened this issue Mar 25, 2021 · 2 comments
Open

No missing-phase-hooks suggestion in buildPythonPackage #100

rmcgibbo opened this issue Mar 25, 2021 · 2 comments

Comments

@rmcgibbo
Copy link
Collaborator

It like the missing-phase-hooks check might not be activated for buildPythonPackage: NixOS/nixpkgs#117614 (comment) (cc @sternenseemann)

@jtojnar
Copy link
Owner

jtojnar commented Mar 25, 2021

Probably because buildPythonPackage passes checkPhase as installCheckPhase to mkDerivation. I wonder if we should use preCheck or preInstallCheck here.

@rmcgibbo
Copy link
Collaborator Author

We have overlays that specifically intercept buildPythonPackage, so we can simply do that. I think for users who don't know about how buildPythonPackage is internally implemented, they're more likely to expect their preCheck hook to run in the python checkPhase (whatever it's called inside mkDerivation being none of their concern).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants