Skip to content
This repository has been archived by the owner on Jul 30, 2022. It is now read-only.

make hover menus a skin option #173

Open
ghost opened this issue Sep 3, 2014 · 2 comments
Open

make hover menus a skin option #173

ghost opened this issue Sep 3, 2014 · 2 comments
Assignees

Comments

@ghost
Copy link

ghost commented Sep 3, 2014

I like this skin, but I don't really like hovering menus. I would prefer to be able to click on them. Foundation seems to have support for this by adding data-options="is_hover: false/true" to the topbar and other menus (e.g. page actions menu). There are just two issues I see right now:

  1. For some reason this commit adds custom JS to handle hovering the page actions menu. If I remove it and try to use the data-options attribute with hover set to true, the page actions menu becomes a toggle hover instead of of a normal hover. That is, I hover my mouse once to activate the menu, move the mouse elsewhere, then hover again to deactivate it. I'm not sure how to fix this, since I'm not much of a web developer
  2. There seems to be a bug with is_hover: false where clicking the button activates the link (appends # to the URL and activates and deactivates the menu near-instantly). This is probably a Foundation issue.
@sjwiki
Copy link

sjwiki commented Sep 3, 2014

If everything was click-accessible as opposed to hover that would make mobile taps and desktop clicks move congruent too. I like this idea.

@jthingelstad
Copy link
Owner

Hmm.. this could be handled as another Foreground option.

@Hutchy68 Hutchy68 self-assigned this Apr 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants