Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unused-prop-types triggered when used in nextProps of UNSAFE_componentWillReceiveProps #2363

Closed
KisaneNeko opened this issue Jul 29, 2019 · 1 comment

Comments

@KisaneNeko
Copy link

KisaneNeko commented Jul 29, 2019

I'm using flow typings and I noticed this error after running script prefixing deprecated lifecycle methods. Basic example:

type Props = {
  dataDirty: boolean
};

class RandomComponent extends Component<Props> {
 UNSAFE_componentWillReceiveProps(nextProps: Props) {
    if (nextProps.dataDirty) {
      doSomething();
   }
 }
}

this triggers 'dataDirty' PropType is defined but prop is never used. When UNSAFE_ prefix is removed the error is gone.

edit: it might be worth to mention, when searching I found this old issue:
#884
But in my case destructuring the nextProps didn't fix the error

@KisaneNeko
Copy link
Author

Issue seems to be gone after updating eslint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants