Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jest switch broke appveyor #2253

Closed
ljharb opened this issue Apr 30, 2019 · 1 comment
Closed

jest switch broke appveyor #2253

ljharb opened this issue Apr 30, 2019 · 1 comment
Assignees
@yannickcr

Comments

@ljharb
Copy link
Member

ljharb commented Apr 30, 2019 •
edited
Loading

I'm not sure why we switched to jest; jest aggressively drops support for older nodes even faster than mocha.

Either way, the jest switch broke appveyor tests.

It'd be great to do this sort of thing by PR; dropping node 4 is unacceptable to me and I intend to revert it. No testing experience is worth dropping back compat support.
This was referenced Apr 30, 2019
Merged
Merged
@yannickcr
Copy link
Member

The drop of Node 4 compatibility is unrelated to the switch to Jest, but I will revert it for now so we can discuss it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yannickcr yannickcr

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yannickcr @ljharb