Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rule boolean-prop-naming does not check nested props. #2041

Closed
zozoens31 opened this issue Nov 12, 2018 · 3 comments · Fixed by #2234
Closed

The rule boolean-prop-naming does not check nested props. #2041

zozoens31 opened this issue Nov 12, 2018 · 3 comments · Fixed by #2234

Comments

@zozoens31
Copy link

zozoens31 commented Nov 12, 2018

When using a shape prop, with a bool prop inside, it is not checked by the rule:

static propTypes = 
  nest: PropTypes.shape({
    eggIsWhite: PropTypes.bool,  // No react/boolean-prop-naming warning here.
  }),
  thisIsChecked: PropTypes.bool,  // react/boolean-prop-naming warning.
}
@pawelnvk
Copy link

This should be fixed with #2234

@jzabala
Copy link
Contributor

jzabala commented Jul 10, 2020

This should be fixed with #2234

@ljharb should this one be closed then?

@ljharb
Copy link
Member

ljharb commented Jul 10, 2020

Yep, thanks :-) closed by #2234.

@ljharb ljharb closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants