Merge pull request #1244 from jseminck/no-array-index-key-bug

[Fix] Treat "key" without value as a valid case instead for "no-array-index-key"
jsx-eslint · Jun 7, 2017 · d77a205 · d77a205
2 parents e28b9d2 + a9d2cf7
commit d77a205
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/rules/no-array-index-key.js b/lib/rules/no-array-index-key.js
@@ -177,8 +177,8 @@ module.exports = {
         }
 
         var value = node.value;
-        if (value.type !== 'JSXExpressionContainer') {
-          // key='foo'
+        if (!value || value.type !== 'JSXExpressionContainer') {
+          // key='foo' or just simply 'key'
           return;
         }
 

diff --git a/tests/lib/rules/no-array-index-key.js b/tests/lib/rules/no-array-index-key.js
@@ -30,6 +30,7 @@ ruleTester.run('no-array-index-key', rule, {
   valid: [
     {code: '<Foo key="foo" />;'},
     {code: '<Foo key={i} />;'},
+    {code: '<Foo key />;'},
     {code: '<Foo key={`foo-${i}`} />;'},
     {code: '<Foo key={\'foo-\' + i} />;'},
 
@@ -71,6 +72,10 @@ ruleTester.run('no-array-index-key', rule, {
       ].join('\n')
     },
 
+    {
+      code: 'foo.map((baz, i) => <Foo key />)'
+    },
+
     {
       code: 'foo.reduce((a, b) => a.concat(<Foo key={b.id} />), [])'
     },