-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
label-has-associated-control controlComponents should allow regex #720
Comments
I'd prefer a glob to a regex string; ie, |
2 cents: I would vote for regex over glob. Regexes are more powerful and I think they're more common in this kind of thing (I've only ever seen globs used for file paths). How would you express |
"More powerful" is a downside, not an upside. I'd expect that example to be |
You say potato, I say potato. 😉 I don't have super strong feelings either way, but the eslint core rules use regexes over globs. |
Depends on which rules you look at. Accepting a regex string opens us up to a host of potential CVEs id rather avoid. |
I created #749 to add glob support 😄 |
See the title. :^)
Ideally, I'd like to be able to specify
"controlComponents": "Input$"
to match any component that ends withInput
(e.g.,<TextInput />
,<EmailInput />
,<BirthdateInput />
, etc.).The text was updated successfully, but these errors were encountered: