Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming of url types #224

Closed
stp-ip opened this issue Feb 21, 2016 · 14 comments
Closed

Consistent naming of url types #224

stp-ip opened this issue Feb 21, 2016 · 14 comments

Comments

@stp-ip
Copy link
Member

stp-ip commented Feb 21, 2016

For the main sections the field should be named website including personal website, company website, project website etc.

For links to more resource like things such as slides, videos, identifiers, downloadables, I would suggest source.

Update: Moving to the suggestion from @aloisdg

@aloisdg
Copy link
Contributor

aloisdg commented Feb 21, 2016

I would prefer a simple source. It is universal, short and widely used.

@olivif olivif changed the title Consistent use of naming url types Consistent naming of url types Feb 21, 2016
@olivif
Copy link
Collaborator

olivif commented Feb 21, 2016

Renamed title slightly. website and source sound good to me!

@phumke
Copy link

phumke commented Feb 21, 2016

+1 to @aloisdg - just source sounds good

@thomasdavis
Copy link
Member

Could someone paste a larger example with source being used, a tiny bit confused.

@stp-ip
Copy link
Member Author

stp-ip commented Feb 22, 2016

@thomasdavis
On the go so a larger example has to wait, but the reasoning is that website is great for showcasing a website, but it might be the wrong word for a link to downloading a publication, or a link to the slides of a presentation etc.

Source therefore could be used for these additional resources provided via a url, which are not a website.
As we move into more generic territory with for example publication probably also applying to talks given, having a slides or video field for urls, is not the best idea, therefore we could add either one source field, or perhaps a sources array with url and label.

Hope that makes the reasoning behind this issue more apparent.

@stp-ip
Copy link
Member Author

stp-ip commented Mar 15, 2016

So the proposition:

  • website for the actual websites.
  • source with a URL and a label field for things such as videos, slides etc. (one source for now - maybe array later?)
  • image either URL or base64 encoded for logo, image or ?showcasing?. See Logo for companies #233

@olivif
Copy link
Collaborator

olivif commented May 3, 2016

+1 for website and source

for image, I would stick with URL for now.

@aloisdg
Copy link
Contributor

aloisdg commented May 9, 2016

I find it a bit cluttering to get source and website but I can understand the use. I am not against.

@stp-ip
Copy link
Member Author

stp-ip commented May 17, 2016

New proposal:

  • website for actual websites
  • source with a URL and a label field for things such as videos, slides, images for showcasing etc.
  • image for company logos or project logos
  • image for profile image instead of picture to make naming more consistent

@aloisdg
Copy link
Contributor

aloisdg commented May 17, 2016

@stp-ip I still find this to heavy

@stp-ip
Copy link
Member Author

stp-ip commented Dec 23, 2016

Ok simplifying and trying to work with this:

  • website for actual websites
  • source with a URL and a label field
  • image for all images (company and profile)

@stp-ip
Copy link
Member Author

stp-ip commented Dec 23, 2016

Closing in favor of #256

Trying to finally get some headway.

@stp-ip stp-ip closed this as completed Dec 23, 2016
@stp-ip
Copy link
Member Author

stp-ip commented Dec 24, 2016

During the PR to make the current schema conform to the specific url types it seems to make more sense to just use url for slides, videos and websites.

We might leave it at url for websites and profiles for now and revisit an array of urls called resources for publications, references or projects (slides, videos, mockups etc.)

@aloisdg
Copy link
Contributor

aloisdg commented Jan 14, 2017

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants