Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v5.2.3 is based on the wrong branch #454

Closed
erayd opened this issue Oct 5, 2017 · 2 comments
Closed

Release v5.2.3 is based on the wrong branch #454

erayd opened this issue Oct 5, 2017 · 2 comments

Comments

@erayd
Copy link
Contributor

erayd commented Oct 5, 2017

The v5.2.3 release was based on the master branch, instead of 5.x.x.

@bighappyface Any chance you could nuke 5.2.3 and roll a 5.2.4 release from the 5.x.x head? That's where 5.2.3 was supposed to point anyway, and incrementing the number (rather than re-releasing 5.2.3) will avoid downstream caching issues.
@erayd erayd mentioned this issue Oct 5, 2017
Closed
@bighappyface
Copy link
Collaborator

Grumpy tag

https://github.com/justinrainbow/json-schema/releases/tag/5.2.4

@erayd
Copy link
Contributor Author

erayd commented Oct 5, 2017

@bighappyface Thanks! That was extremely fast 👍.

@erayd erayd closed this as completed Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erayd @bighappyface