Guidence for running tests locally

[dafeder]

Hi sorry if this seems obvious to some but wondering how the regular contributors are running tests. A quick composer install/composer test fails with

PHP Fatal error:  Uncaught Error: Call to undefined function each() in /home/dfeder/Work/json-schema-php/json-schema/vendor/phpunit/phpunit/src/Util/Getopt.php:38

Could be because locally I have php8.3 which is not officially supported yet? I've been trying to run on other versions using docker, I'm sure I'lll get it eventually but wondering if anyone has a good local workflow they can share.

[DannyvdSluijs]

Seems like a valid question. I think in order to best help out we need to know a bit more about your setup.

I’m using MacOS using brew, a couple of different versions of PHP installed and switching runtime using either brew-php-switcher and letting PHPStorm set the correct runtime.

Also this “issue” is again another point for supporting newer PHP versions in order for people to contribute easier.

[Seldaek]

Yeah I feel like this will get simplified once we can drop old php versions, probably not worth spending too much energy on right now.

[dafeder]

I'm on Linux and usually work in VS Code, but generally I don't do any IDE integration for test running I just have my projects containerized and run test commands from the CLI. I bet there is something equivalent for VS Code, I can do a little research. It might be nice to include some docs with reasonably platform-agnostic steps to build and run tests on all the PHP versions supported, but maybe in 2024 we just expect PHP devs to have their own workflow for this kind of thing?

And yeah supporting up to PHP 8.3 should probably be a priority. I wonder is it just the tests that break or would the library itself fail on 8.3?

[DannyvdSluijs]

I've been playing around a bit with a docker run command and came to

docker run -v `pwd`:/src -w /src php:7.1-cli php -d memory_limit=-1 ./vendor/bin/phpunit

Which has the following output:

PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

Runtime:        PHP 7.2.34
Configuration:  /src/phpunit.xml.dist

.............................................................   61 / 1970 (  3%)
.............................................................  122 / 1970 (  6%)
.............................................................  183 / 1970 (  9%)
.............................................................  244 / 1970 ( 12%)
.............................................................  305 / 1970 ( 15%)
.............................................................  366 / 1970 ( 18%)
.............................................................  427 / 1970 ( 21%)
.............................................................  488 / 1970 ( 24%)
.............................................................  549 / 1970 ( 27%)
.............................................................  610 / 1970 ( 30%)
.............................................................  671 / 1970 ( 34%)
...........................................S.................  732 / 1970 ( 37%)
.............................................................  793 / 1970 ( 40%)
.............................................................  854 / 1970 ( 43%)
.............................................................  915 / 1970 ( 46%)
.............................................................  976 / 1970 ( 49%)
............................................................. 1037 / 1970 ( 52%)
............................................................. 1098 / 1970 ( 55%)
............................................................. 1159 / 1970 ( 58%)
............................................................. 1220 / 1970 ( 61%)
............................................................. 1281 / 1970 ( 65%)
............................................................. 1342 / 1970 ( 68%)
............................................................. 1403 / 1970 ( 71%)
............................................................. 1464 / 1970 ( 74%)
............................................................. 1525 / 1970 ( 77%)
............................................................. 1586 / 1970 ( 80%)
............................................................. 1647 / 1970 ( 83%)
............................................................. 1708 / 1970 ( 86%)
............................................................. 1769 / 1970 ( 89%)
............................................................. 1830 / 1970 ( 92%)
............................................................. 1891 / 1970 ( 95%)
............................................................. 1952 / 1970 ( 99%)
..................

Time: 4.56 seconds, Memory: 116.00MB

There was 1 skipped test:

1) JsonSchema\Tests\Constraints\RequiredPropertyTest::testInvalidCasesUsingAssoc with data set #10 ('{\n                  "array":{...     }', '{\n                  "type":"o...     }', 1)
Test indicates that it is not for "CHECK_MODE_TYPE_CAST"

/src/tests/Constraints/BaseTestCase.php:65
phpvfscomposer:///src/vendor/phpunit/phpunit/phpunit:51

OK, but incomplete, skipped, or risky tests!
Tests: 1970, Assertions: 6234, Skipped: 1.

You only have to pick the same PHP version that was used to install dependencies. Hoop this helps.