Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-release-tooling]: Minor fixes web tooling page #913

Merged

Conversation

DarhkVoyd
Copy link
Member

@DarhkVoyd DarhkVoyd commented Sep 3, 2024

What kind of change does this PR introduce?
This PR aims to fix minor bugs, inconsistencies and more, before the web tooling page release.

Checklist:

  • Add redirects for each relative path at /implementations to the specific new filter in the new page at /tools
  • Fix sidebar dropdown scrollbar only visible on scroll/hover
  • Fix MainNavLink for /tools does not reset filters

Issue Number:
Related to #716

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@DarhkVoyd DarhkVoyd marked this pull request as ready for review September 3, 2024 15:45
@DarhkVoyd DarhkVoyd requested a review from a team as a code owner September 3, 2024 15:45
Copy link

github-actions bot commented Sep 3, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 015268d

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (07c10c5) to head (015268d).
Report is 9 commits behind head on web-release-tooling.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           web-release-tooling      #913   +/-   ##
=====================================================
  Coverage               100.00%   100.00%           
=====================================================
  Files                       10        10           
  Lines                      373       373           
  Branches                    94        94           
=====================================================
  Hits                       373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great one step closer!

@benjagm benjagm merged commit 48eed07 into json-schema-org:web-release-tooling Sep 4, 2024
4 of 5 checks passed
benjagm added a commit that referenced this pull request Sep 4, 2024
* [data]: Data Preparation for Improved Data Model (#738)

* add validators to updated tooling data

* migrate hardcoded tooling data to updated model

* refine structure

* fix, clean, and add environment field

* add dependsOnValidators field

* remove empty fields

* conform to ecosystem tooling identification schema

* remove incorrect draft

* fix apache 2.0 license to spdx identifier

* [pages][tools]: Redesign UI/UX for Tooling Page (#808)

* initial redesign migration

* remove environments groupby

* add trigger update landscape tooling workflow (#838)

* [pages][tools]: Implement Tooling Analytics and Integrate Bowtie Report (#858)

* [pages][tools]: Prepare Tooling Page for Release

Closes: #780

* improve dropdownmenu and sidebar with svgr logo

better sidebar

better tooling table

* add ToolingTable

* fix sidebar and query params

* improve tooling data table

fix

* fix mobile responsive

* use css columns in modal

* use modal svgr icon

remove margins in tooling modal

* add initial analytics

* add sort by bowtie

* add analytics schema and fix sidebar bug

* fix CORS error

redirect follow is critical. Also, setting content-type header to
text/plain is critical, even if sending JSON, as "text/plain" does not
trigger the browser's preflight requests (which are unsupported by
Google here)

* update schema to remove source and homepage

* update yarn lock

* update call to action and issue template

* Pushed changes to improve style

* update dependencies

* fix json path types build error

* remove unused file

* update redirects

* update internal links

* fix linting errors

* add backend api

* fix bowtie api integration and add skeleton placeholder

* fix bowtie served over https

* sort toolingData drafts

* fix bowtie skeleton width style

* fix bowtie skeleton width

* add native title based tooltip

---------

Co-authored-by: Benjamin Granados <[email protected]>

* [data]: Sync and finalise tooling data (#899)

* sync tooling data

* add tooling data validation workflow and fix JSONSchemaTool interface

* fix undefined error

* use corepack and yarn in workflow

* fix tooling data

* fix tooling data draft

* Added 2 last tools

---------

Co-authored-by: Benjamin Granados <[email protected]>

* [web-release-tooling]: Minor fixes web tooling page (#913)

* add /implementations to /tools redirects

* fix /tools sidebar dropdown scrollbar

* fix nav link does not reset filters

* fix redirect typo

* update yarn lock

* fix redirects

* move wild card redirect to last

* fix dependencies problem

---------

Co-authored-by: Benjamin Granados <[email protected]>

* Removing old data files

* update the implementers workflow

---------

Co-authored-by: Benjamin Granados <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants