Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable analytics data on development mode #1134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

saurabhraghuvanshii
Copy link

What kind of change does this PR introduce?

Bug As mention in #1096 is fixed , there will be no analytics data should be posted in development mode which occurs in /tools Tooling page.

Issue Number:

no

If relevant, did you update the documentation?

no

Summary

bug #1096 is resolve by this pr as we can see in development mode postAnalytics function run but it not needed in dev mode , so this PR disable analytics tracking during development mode.

Does this PR introduce a breaking change?
no

@saurabhraghuvanshii saurabhraghuvanshii requested a review from a team as a code owner November 23, 2024 18:45
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1666a67) to head (1c1ad8d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

github-actions bot commented Nov 23, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 1c1ad8d

Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this. Looks good to me.

@saurabhraghuvanshii
Copy link
Author

@DarhkVoyd my Pleasure .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Disable Tooling Page analytics posting during dev mode to ensure accurate trend reports
2 participants