-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable analytics data on development mode #1134
base: main
Are you sure you want to change the base?
fix: disable analytics data on development mode #1134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for fixing this. Looks good to me.
@DarhkVoyd my Pleasure . |
What kind of change does this PR introduce?
Bug As mention in #1096 is fixed , there will be no analytics data should be posted in development mode which occurs in /tools Tooling page.
Issue Number:
Screenshots/videos:
no
If relevant, did you update the documentation?
no
Summary
bug #1096 is resolve by this pr as we can see in development mode postAnalytics function run but it not needed in dev mode , so this PR disable analytics tracking during development mode.
Does this PR introduce a breaking change?
no