Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug : Update route from /implementations to /tools #394

Closed
aialok opened this issue Feb 29, 2024 · 12 comments
Closed

Bug : Update route from /implementations to /tools #394

aialok opened this issue Feb 29, 2024 · 12 comments
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Stale It's believed that this issue is no longer important to the requestor. Status: Triage This is the initial status for an issue that requires triage.

Comments

@aialok
Copy link
Member

aialok commented Feb 29, 2024

Describe the bug

  • Basically we have updated our implementation page to tools but we have not updated the corresponding route.

How to Reproduce

  • Go to json-schema-website
  • Navigate to tools section and see the URL

Screenshot from 2024-02-29 23-33-39

Expected behavior

@DhairyaMajmudar
Copy link
Member

Good find @aialok : D

@officeneerajsaini
Copy link
Contributor

Yeah, that's great, @aialok . We need to change the route from 'implementation' to 'tools' and also create a redirection route so we can redirect '/implementation' to '/tools.

@aialok
Copy link
Member Author

aialok commented Mar 1, 2024

Yeah, that's great, @aialok . We need to change the route from 'implementation' to 'tools' and also create a redirection route so we can redirect '/implementation' to '/tools.

Yupp @officeneerajsaini , we are also facing page not found error in mobile phone. Because of this only.

@officeneerajsaini
Copy link
Contributor

It issue not only occur in mobile it also occur in any other devices because we try to get request from a route that not exits so , we need to make changes in route and also need to make a redirect link so if someone try to get request on "/implementations" route it will redirect to "/tools"
@aialok

@benjagm
Copy link
Collaborator

benjagm commented Mar 1, 2024

The implementations url is probably being used from hundreds of sites se we can't just remove the link. The ideal solution is rename this page to tools but also create a redirect in cloudflare to make sure all call to implementations end up in tools.

@benjagm benjagm added ✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Triage This is the initial status for an issue that requires triage. labels Mar 1, 2024
@aialok
Copy link
Member Author

aialok commented Mar 1, 2024

The implementations url is probably being used from hundreds of sites se we can't just remove the link. The ideal solution is rename this page to tools but also create a redirect in cloudflare to make sure all call to implementations end up in tools.

@benjagm, yes, this is the good to go but cloudflare work will be done by you only.
Additionally, I noticed a few typos on the "Tools" page. I think Instead of "implementation," we need to use "tools" everywhere.

Screenshot from 2024-03-01 15-19-03
Screenshot from 2024-03-01 15-18-32

@AdityaSingh-02
Copy link
Contributor

AdityaSingh-02 commented Mar 4, 2024

The implementations url is probably being used from hundreds of sites se we can't just remove the link. The ideal solution is rename this page to tools but also create a redirect in cloudflare to make sure all call to implementations end up in tools.

@benjagm, Yes I completely agree with you, changing the route is not an Ideal Solution since many sites/clients must be using /implementations URLs, the possible solution is fix the page content and change it from tooling to implementations

And I am not sure but implementations page needed a redesign to improve UX #160

@benjagm I was Wondering if I could work on this issue.🚀

@divyaxdv
Copy link
Contributor

divyaxdv commented Mar 5, 2024

@benjagm, Yes I completely agree with you, changing the route is not an Ideal Solution since many sites/clients must be using /implementations URLs, the possible solution is fix the page content and change it from tooling to implementations

And I am not sure but implementations page needed a redesign to improve UX #160

@benjagm I was Wondering if I could work on this issue.🚀

@AdityaSingh-02 ,changing the content of the page from tool to implementation is not viable i guess, I dont think that is how this should be proceeded as the implementation page has been updated to Tools knowingly.
The solution suggested by @benjagm is ideal but cloudfare work can be done by him only.

@benjagm
Copy link
Collaborator

benjagm commented Mar 5, 2024

@AdityaSingh-02 @divyaxdv . We will need to review the in the whole site the usage of implementations to adopt the new term tools and we all of that is done, well proceed with:

  • Rename the page from implementations to /tools
  • Creating a redirect here from /implementations to /tools

@officeneerajsaini
Copy link
Contributor

It issue not only occur in mobile it also occur in any other devices because we try to get request from a route that not exits so , we need to make changes in route and also need to make a redirect link so if someone try to get request on "/implementations" route it will redirect to "/tools" @aialok

@benjagm Yeah, I already mentioned that. However, we need to carefully change the route. We need to check every link to ensure they work properly because there are a lot of links.

@benjagm benjagm moved this from Todo to On Hold in Website Contributor Board Mar 13, 2024
Copy link

github-actions bot commented Jun 2, 2024

Hello! 👋

This issue has been automatically marked as stale due to inactivity 😴

It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details.

There can be many reasons why a specific issue has no activity. The most probable cause is a lack of time, not a lack of interest.

Let us figure out together how to push this issue forward. Connect with us through our slack channel : https://json-schema.org/slack

Thank you for your patience ❤️

@github-actions github-actions bot added the Status: Stale It's believed that this issue is no longer important to the requestor. label Jun 2, 2024
@benjagm
Copy link
Collaborator

benjagm commented Sep 23, 2024

Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Stale It's believed that this issue is no longer important to the requestor. Status: Triage This is the initial status for an issue that requires triage.
Projects
None yet
Development

No branches or pull requests

6 participants