-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug : Update route from /implementations to /tools #394
Comments
Good find @aialok : D |
Yeah, that's great, @aialok . We need to change the route from 'implementation' to 'tools' and also create a redirection route so we can redirect '/implementation' to '/tools. |
Yupp @officeneerajsaini , we are also facing page not found error in mobile phone. Because of this only. |
It issue not only occur in mobile it also occur in any other devices because we try to get request from a route that not exits so , we need to make changes in route and also need to make a redirect link so if someone try to get request on "/implementations" route it will redirect to "/tools" |
The implementations url is probably being used from hundreds of sites se we can't just remove the link. The ideal solution is rename this page to tools but also create a redirect in cloudflare to make sure all call to implementations end up in tools. |
@benjagm, yes, this is the good to go but cloudflare work will be done by you only. |
@benjagm, Yes I completely agree with you, changing the route is not an Ideal Solution since many sites/clients must be using /implementations URLs, the possible solution is fix the page content and change it from tooling to implementations And I am not sure but implementations page needed a redesign to improve UX #160 @benjagm I was Wondering if I could work on this issue.🚀 |
@AdityaSingh-02 ,changing the content of the page from tool to implementation is not viable i guess, I dont think that is how this should be proceeded as the implementation page has been updated to Tools knowingly. |
@AdityaSingh-02 @divyaxdv . We will need to review the in the whole site the usage of implementations to adopt the new term tools and we all of that is done, well proceed with:
|
@benjagm Yeah, I already mentioned that. However, we need to carefully change the route. We need to check every link to ensure they work properly because there are a lot of links. |
Hello! 👋 This issue has been automatically marked as stale due to inactivity 😴 It will be closed in 180 days if no further activity occurs. To keep it active, please add a comment with more details. There can be many reasons why a specific issue has no activity. The most probable cause is a lack of time, not a lack of interest. Let us figure out together how to push this issue forward. Connect with us through our slack channel : https://json-schema.org/slack Thank you for your patience ❤️ |
Completed. |
Describe the bug
How to Reproduce
Expected behavior
The text was updated successfully, but these errors were encountered: