Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The old site notes about compatibility are missing in the implementations page. #270

Closed
benjagm opened this issue Jan 10, 2024 · 1 comment · Fixed by #271
Closed

The old site notes about compatibility are missing in the implementations page. #270

benjagm opened this issue Jan 10, 2024 · 1 comment · Fixed by #271
Labels
🐛 Bug Indicates that the issue is a bug or defect.

Comments

@benjagm
Copy link
Collaborator

benjagm commented Jan 10, 2024

Describe the bug

The old site notes about compatibility are missing in the implementations page.

This is how this was shown in the old site:
Screenshot 2024-01-10 at 13 18 13

And this is the old code of the old site with the missing logic:

    {% if implementation.compliance %}
      <li><em>Compliance:</em>
      {% if implementation.compliance.config.docs %}
        This implementation <a href="{{ implementation.compliance.config.docs }}">documents</a> that you must
      {% endif %}
      {% if implementation.compliance.config.instructions %}
        <strong>{{ implementation.compliance.config.instructions | markdownify | remove: '<p>' | remove: '</p>' }}</strong> to produce specification-compliant behavior.
      </li>
      {% endif %}
    {% endif %}

Expected behavior

The expectations is to add the compliance notes after the notes.

@benjagm benjagm added the 🐛 Bug Indicates that the issue is a bug or defect. label Jan 10, 2024
@Relequestual Relequestual linked a pull request Jan 11, 2024 that will close this issue
@benjagm
Copy link
Collaborator Author

benjagm commented Jan 11, 2024

This is fixed in this PR: #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant