Issues with the Pro-Help page

[jdesrosiers]

The https://json-schema.org/pro-help page was recently added. While adding my bio, I noticed several issues now that we have more than one bio on the page.

• Inconsistent sizing of avatars -- Juan's is rendering bigger that the others for some reason, which also makes the layout between the cards not line up.
• No padding between the listings -- A little spacing would look nicer.
• The bio should use the markdown component -- Plain text is too limiting.

This screenshot comes from running the site locally with the additional entries.

[DhairyaMajmudar]

Thank you Jason for reporting the issue.

[arpitkuriyal]

hey @DhairyaMajmudar , Can you assign this issue to me?

[Thund3rHawk]

Hey @DhairyaMajmudar , I hope you are doing well , I'd love to work on this issue , can I work on this if you assign me.

[jagpreetrahi]

Hi @jdesrosiers, I hope you're doing well! This issue seems quite similar to issue #1289, which I had already resolved and submitted a pull request for. That PR is currently pending for review/merge. You might find it helpful to take a look at it for reference.
Let me know if there's anything else I can assist with!

[jdesrosiers]

From the markdown-to-jsx README (which is what the <StyledMarkdown> component is using):

By default, the compiler will try to make an intelligent guess about the content passed and wrap it in a <div>, <p>, or <span> as needed to satisfy the "inline"-ness of the markdown.

The component is trying to guess whether the content should be rendered as an inline element or a block element. The problem is that it's guessing differently for each bio. We need to force it to always render as a block for all bios.

The solution is to set the forceBlock option on the <Markdown> component. This ensures that all markdown gets rendered the same way. If there are places on the site where we actually need an inline block we can add a prop to <StyledMarkdown> to force inline mode (forceInline) instead. I think it's very unlikely that we need that. I'd be surprised if inline mode was ever what we actually want.

[jagpreetrahi]

Yeah it's better for uniform rendering . And I think this approach keeps it simple and consistent

[jagpreetrahi]

hey @jdesrosiers , can I try with markdown to jsx package locally , and see what happens with that

[jdesrosiers]

@jagpreetrahi I posted that in the wrong place. I meant to post it in the PR that's working on this issue. Sorry that it looked like I was responding to you. Let's let them continue their work in the PR.

[jagpreetrahi]

Alright

[Vishv0407]

Hello @jdesrosiers still is this issue open ?, if yes then I want to work on this.

[jdesrosiers]

This has been completed. Sorry for the confusion. However, there is a follow up issue that we need some feedback and new ideas for if you want to get involved there.