Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Bad contrast in the blog's dark theme in info boxes #1070

Open
jaller94 opened this issue Oct 27, 2024 · 9 comments · May be fixed by #1131 or #1143
Open

🐛 Bug: Bad contrast in the blog's dark theme in info boxes #1070

jaller94 opened this issue Oct 27, 2024 · 9 comments · May be fixed by #1131 or #1143
Assignees
Labels
🐛 Bug Indicates that the issue is a bug or defect. good first issue Good for newcomers Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@jaller94
Copy link

Describe the bug

The text in info boxes cannot be read.

Steps To Reproduce

  1. Set your browser to prefer the dark theme.
  2. Go to https://json-schema.org/blog/posts/applicability-json-schema-fundamentals-part-1#putting-everything-together-avoiding-oneof-pitfalls
  3. Look for any of the many info boxes.
  4. The text is not legible.

Expected Behavior

Proper contrast of the font and the background for the dark theme

Screenshots

2024-10-27_13-49_1

The light theme looks ok:

2024-10-27_13-49

Device Information [optional]

- OS: Manjaro
- Browser: Firefox
- version: 131.0.2

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No

@jaller94 jaller94 added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Oct 27, 2024
@DhairyaMajmudar
Copy link
Member

Thanks for reporting the issue @jaller94

@DhairyaMajmudar DhairyaMajmudar added good first issue Good for newcomers Status: Available No one has claimed responsibility for resolving this issue. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Hacktoberfest Issues accepeted Hacktoberfest'24 and removed Status: Triage This is the initial status for an issue that requires triage. labels Oct 27, 2024
@pavanydg
Copy link

@DhairyaMajmudar pl assign me.

@DhairyaMajmudar
Copy link
Member

Go ahead @pavanydg 🚀

@ayushk-1801
Copy link

ayushk-1801 commented Nov 22, 2024

@DhairyaMajmudar please assign me

@souvikjs01
Copy link

if the issue is still open, can you assign me @DhairyaMajmudar

@pavanydg pavanydg removed their assignment Nov 23, 2024
@ritwik-69
Copy link

@DhairyaMajmudar can i work on this issue?

@DhairyaMajmudar
Copy link
Member

Sure @ritwik-69 looking forward for your PR

@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Available No one has claimed responsibility for resolving this issue. Hacktoberfest Issues accepeted Hacktoberfest'24 labels Nov 28, 2024
@ritwik-69
Copy link

image
@DhairyaMajmudar I am getting this error while committing can you tell me how t o fix this?

@DhairyaMajmudar
Copy link
Member

It's causing since you're using yarn V1 whereas the repo supports yarn V4, you can install latest yarn version by following the guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Indicates that the issue is a bug or defect. good first issue Good for newcomers Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
6 participants