-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Multiple $ref within single object using Object.assign() #158
Comments
I'm interested too! |
BTW, JSON is not JavaScript, and JSON Schema implementations are written in many languages, so JSON Schema features should not be described in terms of JavaScript/ECMAScript features like Object.assign(). Media types for patching (as referenced in #15 and #98) are a more appropriate reference point. |
@handrews I think the consensus is moving towards keeping merging functionality outside of the spec? In any case I'd close it as essentially a duplicate of other similar ideas... |
@epoberezkin I think you are right about the outside-of-the-spec approach, at least for non-schema-aware general JSON merging (#15 and to a lesser degree #98). And despite coming up with #119 I'm not actually a huge fan of it! Anyway, this issue should be closed as a duplicate unless @erikfox or other commenters think we're missing something in those other issues. |
@erikfox it's been over a month since we suggested closing this in favor of other pre-existing issues, so I'm taking your lack of response as being OK with closing it. Please feel free to re-open if you think I'm missing something- just include a comment about what still needs to be addressed. But mostly I think this is a dup of #15 with an alternate syntax. |
It would be very useful to be able to merge references within an object:
This would use
Object.assign()
, which also provides a convention in the case of objects with the same properties:The text was updated successfully, but these errors were encountered: