Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django 2.0 compatibility #146

Closed
BarnabasSzabolcs opened this issue Jul 27, 2018 · 8 comments
Closed

Django 2.0 compatibility #146

BarnabasSzabolcs opened this issue Jul 27, 2018 · 8 comments

Comments

@BarnabasSzabolcs
Copy link

user_or_ip uses user.is_authenticated() which is a bool not a function in Django 2.0.
@adamchainz
Copy link
Collaborator

Not since #136

I think we are just pending a release, @jsocol ?

@jsocol
Copy link
Owner

jsocol commented Aug 18, 2018

Correct, I can get to that next week!

@jsocol jsocol closed this as completed Aug 18, 2018
@adamchainz
Copy link
Collaborator

@jsocol still need that release! Last one was nearly a year ago.

@MatonAnthony MatonAnthony mentioned this issue Nov 11, 2018
Merged
2 tasks
@adamchainz
Copy link
Collaborator

👈prod

If you want you can make me maintainer on PyPI too and I can do it!

@jsocol
Copy link
Owner

jsocol commented Nov 17, 2018

@adamchainz you already are, go for it!

@jsocol
Copy link
Owner

jsocol commented Dec 29, 2018

Getting a couple of things added in #125, #156, #159 at least

@jsocol
Copy link
Owner

jsocol commented Dec 29, 2018

Released as version 2.0, because of the wide swing in Django version support. Thanks all!

@adamchainz
Copy link
Collaborator

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsocol @adamchainz @BarnabasSzabolcs