Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robot-interface.l: add go-* function prototype #163

Merged
merged 4 commits into from
Oct 13, 2015

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Aug 8, 2015

@k-okada
Copy link
Member Author

k-okada commented Aug 8, 2015

from @snozawa

hrpsysのgoPosはnowait方式ですが、
https://github.com/fkanehiro/hrpsys-base/blob/master/idl/AutoBalancerService.idl#L195
Euslispではこれを明示的にgo-pos-no-waitとしていて、
:go-posはwaitありにしています。
https://github.com/start-jsk/rtmros_common/blob/master/hrpsys_ros_bridge/euslisp/rtm-ros-robot-interface.l#L716

このへんはむかしのpluginの時代からの歴史的な経緯でかつpr2-interface.lと同じようにするために
この状態にしています。

waitする関数はeuslispでは:wait-foot-steps
になります

[pr2eus/robot-inferface.l] clarify return value policy
@garaemon
Copy link
Member

I prefer "error" instead of "warn"

@snozawa
Copy link
Contributor

snozawa commented Sep 16, 2015

I prefer "error" instead of "warn"

+1

@k-okada
Copy link
Member Author

k-okada commented Sep 25, 2015

ok, updated

@snozawa
Copy link
Contributor

snozawa commented Sep 25, 2015

👍

k-okada added a commit that referenced this pull request Oct 13, 2015
robot-interface.l: add go-* function prototype
@k-okada k-okada merged commit 8339463 into jsk-ros-pkg:master Oct 13, 2015
@k-okada k-okada deleted the add_temp_go branch October 13, 2015 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants