From b4f13b9ecc7e5dd7bc22b19f34b8a8fef7aad54a Mon Sep 17 00:00:00 2001 From: Kentaro Wada Date: Tue, 25 Jul 2017 16:20:48 +0900 Subject: [PATCH 1/2] Return false response in data_collection_server --- jsk_data/node_scripts/data_collection_server.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/jsk_data/node_scripts/data_collection_server.py b/jsk_data/node_scripts/data_collection_server.py index be2eb2555..434357ec8 100755 --- a/jsk_data/node_scripts/data_collection_server.py +++ b/jsk_data/node_scripts/data_collection_server.py @@ -179,8 +179,10 @@ def service_cb(self, req): abs(now - stamp) < rospy.Duration(self.slop)): saving_msgs[topic['name']] = self.msg[topic['name']]['msg'] if now < stamp: - rospy.logwarn( - 'timestamp exceeds starting time, try bigger slop') + msg = 'timeout for topic [{}]. try bigger slop'.format( + topic['name']) + rospy.logerr(msg) + return TriggerResponse(success=False, message=msg) rospy.sleep(self.slop) save_dir = osp.join(self.save_dir, str(now.to_nsec())) if not osp.exists(save_dir): From e9d6ef8956e3f2de80594bb2030fd72b0e2a350b Mon Sep 17 00:00:00 2001 From: Kentaro Wada Date: Tue, 25 Jul 2017 16:22:35 +0900 Subject: [PATCH 2/2] Sleep less time in data_collection_server.py --- jsk_data/node_scripts/data_collection_server.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jsk_data/node_scripts/data_collection_server.py b/jsk_data/node_scripts/data_collection_server.py index 434357ec8..e8cd099d7 100755 --- a/jsk_data/node_scripts/data_collection_server.py +++ b/jsk_data/node_scripts/data_collection_server.py @@ -183,7 +183,7 @@ def service_cb(self, req): topic['name']) rospy.logerr(msg) return TriggerResponse(success=False, message=msg) - rospy.sleep(self.slop) + rospy.sleep(0.01) save_dir = osp.join(self.save_dir, str(now.to_nsec())) if not osp.exists(save_dir): os.makedirs(save_dir)