fix workflow #347
Closed
fix workflow #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, I can migrate to Undici, which still supports CommonJS and is faster than Got. And it won't be necessary to use a try-catch when it throws a 404. |
UlisesGascon
approved these changes
Dec 20, 2024
|
I love more the idea of using Undici #352, but anyway I am happy to land this change first in case that we don't want to change library. Both options are fine for me. Thanks @bjohansebas for doing this! |
|
Close in favor of #355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the automation. The issue was that
gotthrows an exception when it returns a status code outside of the 2xx and 3xx range.Fun fact: while trying to fix this with
undici, the PR size was larger, but with this change, the PR is smaller (The one that generates the automation).