Update custom-types.json #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleytodd
approved these changes
Jan 12, 2025
There was a problem hiding this comment.
Hm, I am not sure how I feel about these. I don't really see anything wrong with adding them if they are used in the wild, but if they are deprecated then I am also not sure why adding them now add's value.
I will add an approval and see if we can get some more feedback on these. Feel free to post more details about the impact of not including these so we can decide if we wan to merge this.
UlisesGascon
approved these changes
Jan 13, 2025
bjohansebas
approved these changes
Jan 13, 2025
|
Ok, got a few more approvals. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds support for compressed types that, despite being deprecated by iana, are still being used by windows.
Added MIME Types:
Mime: application/x-zip-compressed
Extension: zip
Notes: Windows use this mime-type for Zip files instead of application/zip.
Sources: (https://bugs.python.org/issue41738)
(https://developer.mozilla.org/en-US/docs/Web/HTTP/MIME_types/Common_types)
application/x-compressed
Extension: rar
Notes: Windows 11 use this mime-type for RAR files instead of application/x-rar-compressed or application/vnd.rar