Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests using deep-equal won't fail #38

Closed
alex7kom opened this issue Aug 12, 2021 · 1 comment
Closed

Tests using deep-equal won't fail #38

alex7kom opened this issue Aug 12, 2021 · 1 comment
Labels

Comments

@alex7kom
Copy link

alex7kom commented Aug 12, 2021

Some tests in this project use deep-equal module instead of assert.deepEqual(), however deep-equal never throws, it just returns a boolean, so the tests with just deep-equal will never fail. Tests with deep-equal should probably use assert.ok().

@dougwilson
Copy link
Contributor

Wow, you are right. Great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants