Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ical/.ics issue #16

Closed
tjcflys opened this issue Jul 11, 2016 · 9 comments
Closed

ical/.ics issue #16

tjcflys opened this issue Jul 11, 2016 · 9 comments
Labels

Comments

@tjcflys
Copy link

tjcflys commented Jul 11, 2016

Have not been able to get iCalendar option to work with recent releases of iOS. I verified that your formatting is correct using the validator at icalendar.org. Could it be an issue with downloadjs? Any help would be greatly appreciated.

@jshor
Copy link
Owner

jshor commented Jul 11, 2016

It's indeed an issue with downloadjs. Unfortunately downloadjs doesn't work with Safari. I have plans to fix this soon with FileSaver however (see: http://stackoverflow.com/questions/12802109/download-blobs-locally-using-safari)

@tjcflys
Copy link
Author

tjcflys commented Jul 12, 2016

I think that question might have been referring to Safari for OS. I tried filesaver and it does not seem to work. Filesaver's own documentation informs that it will not work with iOS. I decided to create the file server side and then serve it. Thanks for the help and good luck!

@jshor
Copy link
Owner

jshor commented Jul 18, 2016

@tjcflys you're right, there are issues with iOS using FileSaver.js:

saveAs must be run within a user interaction event such as onTouchDown or onClick; setTimeout will prevent saveAs from triggering.

However I don't think this will be a problem with the dlIcal() function so I used angular-file-saver (a wrapper for FileSaver.js). It works on Safari desktop at least.

If you have a chance, could you please clone this repo and checkout to develop to see if the issue is fixed on iOS/safari? Thanks!

@jshor
Copy link
Owner

jshor commented Jul 20, 2016

This appears to work in iOS versions I've tested - the latest fix is in v1.2.0

@jshor jshor closed this as completed Jul 20, 2016
@tjcflys
Copy link
Author

tjcflys commented Jul 21, 2016

Sorry it took so long to get back to you man. I just tried 1.2.0 on 2 different Apple devices with no luck. Screenshot is attached if that helps.
image

@jshor
Copy link
Owner

jshor commented Jul 21, 2016

Hey @tjcflys no worries - sorry to hear that the fix didn't work. I'm going to re-open this issue.

@jshor jshor reopened this Jul 21, 2016
@fierysolid
Copy link

Any news on this? I've been googling like mad to find a solution.

@jshor
Copy link
Owner

jshor commented Aug 11, 2016

@fierysolid unfortunately no, sorry. According to this it looks like iOS Safari will always render the file name as "Unknown."

I might end up implementing browser detection for Safari and having the menu not show options for icalendar on iOS safari.

@jshor jshor closed this as completed Sep 1, 2017
@jhallmusic
Copy link

Hi @jshor I noticed you closed this a couple months ago, is there still no solution? I'm still experiencing this, and it seems that maybe there's a fix from the link you provided above. thanks!

@jshor jshor removed the help wanted label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants