Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquotes mis-handling subsequent lines at same quote level? #46

Open
Peter-Sparksuite opened this issue May 29, 2024 · 0 comments
Open

Comments

@Peter-Sparksuite
Copy link

Peter-Sparksuite commented May 29, 2024

From what I can see, in GitHub, GitLab and Slack comment/note editors, that a blockquote being started is supposed to include, as part of the quote, subsequent content that follows, until an empty line is encountered.

However, slackify-markdown seems to be translating each subsequent line into double-newline then content, which causes those subsequent lines of content to not be included in the blockquote.

When this converted output is then used to create messages composed via Slack's API, it appears to break the output. ie: the additional lines of content are not appearing within the blockquote.

Here is an example of what I'm talking about. The following two blockquotes each show two 'continuation' lines of text as being part of their respective blockquote:

quote 1
quote 1b
quote 1c

quote 2
quote 2b
quote 2c

Within each blockquote section, the initial line indicates the initiation of a blockquote, the end of the blockquote being an empty newline. Until the blank line, other lines not having a blockquote indication are considered part of the same blockquote.

Here is an example of what the text looks like when editing and creating two separate blockquote sections, the first being a single-deep, the second being double-deep:

> quote 1
quote 1b
quote 1c

>> quote 2
quote 2b
quote 2c

It seems that one too many newline characters are being emitted per subsequent line of text, leading to failure to include those additional lines within the blockquote.

ie, like this:

> quote 1

quote 1b

quote 1c

Would be really nice to have this fixed!

Thank you

Peter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant