Duration toLocaleString - wrong options parameter type

[jakobfdev]

temporal-polyfill/index.d.ts

Line 551 in 2238550

toLocaleString(locales?: string | string[], options?: Intl.DateTimeFormatOptions): string;

The toLocaleString function of Duration still has the Intl.DateTimeFormat type as second parameter. This should - according to spec - be the Intl.DurationFormat type.

Discussion about including the Duration formatting proposal has already started here
#211

Maybe include correct types already - while waiting for a more mature polyfill.

The formatjs polyfill has been developed quite a bit and probably comes with complete typing
see https://www.npmjs.com/package/@formatjs/intl-durationformat

[acontreras89]

I can confirm @formatjs/intl-durationformat provides types for Intl.DurationFormat options.

It's also worth noting that despite the type errors, the polyfill seems to comply with the type of options that can be provided to toLocaleString, something like this will work just fine:

// @ts-expect-error
duration.toLocaleString('en', { style: 'narrow' })