Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Islamic Calendars incorrect dayOfYear #271

Open
MohsenAlyafei opened this issue Dec 17, 2023 · 0 comments
Open

Islamic Calendars incorrect dayOfYear #271

MohsenAlyafei opened this issue Dec 17, 2023 · 0 comments

Comments

@MohsenAlyafei
Copy link

MohsenAlyafei commented Dec 17, 2023

The dayOfYear property does not return the day of the year for the given Islamic calendars' dates but rather to the day of year for the corresponding gregorian calendar.

The first day of this year 1445 AH is day 248 of the islamic year which is incorrect.

This doesn't seem to be correct specification.

This is also the case with the Persian calendar.

Currently to get the dayOfYear is to use the "since" or "until" methods to calculate the day from the start of the given Islamic year.

The weekOfYear is also incorrect for the Islamic calendars and shows the iso week number instead !
The week in Islamic calendar is a simple days since the start of year divide by 7 rounded up to an integer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant