Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin django-ipware dependency in pyproject.toml #388

Closed
mmcclelland1002 opened this issue Nov 29, 2023 · 6 comments · Fixed by #389
Closed

Pin django-ipware dependency in pyproject.toml #388

mmcclelland1002 opened this issue Nov 29, 2023 · 6 comments · Fixed by #389

Comments

@mmcclelland1002
Copy link

django-ipware<=5.0.2

please pin django-ipware in pyproject.toml
@jrobichaud
Copy link
Owner

Can you explain what are the breaking changes?

@jrobichaud
Copy link
Owner

You can still pin it in your requirements.txt.

@jrobichaud jrobichaud mentioned this issue Nov 29, 2023
Merged
@jrobichaud
Copy link
Owner

I am currently releasing 6.0.1 with just this fix.

@jrobichaud
Copy link
Owner

6.0.1 is out with the fix.

Version 7.X of django-structlog will use django-ipware 6+.

@mmcclelland1002 please let me know how it affects django-structlog users.

@jrobichaud
Copy link
Owner

I'd like to provide an appropriate change log / upgrade guide.

@jrobichaud
Copy link
Owner

Is it because of this?

un33k/django-ipware#108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Freeze django-ipware for now jrobichaud/django-structlog
2 participants
@jrobichaud @mmcclelland1002