-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exceptions aren't logged anymore #226
Comments
I'll have to investigate, but I am unavailable this week. Please stick to an earlier version in the meantime. I could not trigger exceptions at all and it appeared to be dead code from an old refactor. I'll have to take a second look. Just to be sure, you are configured as the documentation and did not create a custom class inheriting from RequestMiddleware? |
Yes, I'm using Previously Django called the middleware hook |
The removal was a dumb mistake, I am putting everything back. However, I have to make sure the middleware is stateless in order to work properly with async. The instance is shared between concurrent requests. I'll store the |
@ntap-fge the fix is 5.0.2 that was just released, let me know if you have any problems. Thanks. |
Can confirm that 5.0.2 works fine. Thanks for the quick fix and maintaining django-structlog in general! |
Since version 5.0
RequestMiddleware
doesn't log exceptions anymore (tested with Django 3.2, Python 3.9).The
request_failed
event seems to have been completely removed and the regularrequest_finished
also doesn't contain the exception.The text was updated successfully, but these errors were encountered: