Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider upgrading to datauri version 2 #44

Open
cappslock opened this issue Apr 29, 2019 · 2 comments
Open

Consider upgrading to datauri version 2 #44

cappslock opened this issue Apr 29, 2019 · 2 comments

Comments

@cappslock
Copy link
Contributor

cappslock commented Apr 29, 2019 •
edited
Loading

datauri version 2 contains a fix for a Webpack issue (see here for more context: data-uri/datauri#20)

Upgrading to that version would help folks that are webpacking this package or its dependents to avoid a workaround.

Happy to submit a PR for this if desired. Thanks!
@jrit
Copy link
Owner

jrit commented Apr 30, 2019

yeah, I'd be happy to take a PR to upgrade a dep, especially if it is non-breaking and fixes an issue :)

@cappslock
Copy link
Contributor Author

#45

Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrit @cappslock