From 45591235951b891c3200a9a2e91dbf75c4ee5da0 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Sun, 11 Feb 2024 02:27:51 +0100 Subject: [PATCH] GH Actions: minor tweaks * Remove `--checkstyle` for a lint job which doesn't display with `cs2pr`. * Remove a stray condition. --- .github/workflows/quicktest.yml | 2 +- .github/workflows/unit-tests.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/quicktest.yml b/.github/workflows/quicktest.yml index 547b0518d..b1aff3188 100644 --- a/.github/workflows/quicktest.yml +++ b/.github/workflows/quicktest.yml @@ -57,7 +57,7 @@ jobs: - name: Lint PHP files against parse errors if: ${{ matrix.dependencies == 'stable' }} - run: composer lint -- --checkstyle + run: composer lint - name: Run the unit tests without code coverage if: ${{ github.ref_name != 'develop' }} diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 3d7bfd6dd..c427e16ff 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -119,7 +119,7 @@ jobs: custom-cache-suffix: $(date -u "+%Y-%m") - name: "Composer: downgrade PHPCS dependencies for tests (lowest)" - if: ${{ ! startsWith( matrix.php, '8' ) && matrix.dependencies == 'lowest' }} + if: ${{ matrix.dependencies == 'lowest' }} run: > composer update --prefer-lowest --no-scripts --no-interaction squizlabs/php_codesniffer