Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup-java input of false is ignored #7

Closed
dmurat opened this issue Apr 14, 2022 · 1 comment
Closed

setup-java input of false is ignored #7

dmurat opened this issue Apr 14, 2022 · 1 comment
Assignees

Comments

@dmurat
Copy link

dmurat commented Apr 14, 2022

I'm trying to use non-default Java runtime with release-action, but without success.
I tried to configure setup-java with both false and "false", but release-action always uses the default Zulu 17 runtime.

I might be wrong, but it looks like the problem is in action.yml at line 35:

if: ${{ inputs.setup-java }} == 'true' || ${{ inputs.setup-java }} == true

I believe that the second condition will be truthy if anything non-empty is configured for setup-java

@aalmiray
Copy link
Member

Release 2.1.2 has the fix, as well as v2 branch.

@aalmiray aalmiray self-assigned this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants