Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set the setup-java input to false #10

Closed
dmurat opened this issue Oct 28, 2022 · 2 comments
Closed

Cannot set the setup-java input to false #10

dmurat opened this issue Oct 28, 2022 · 2 comments

Comments

@dmurat
Copy link

dmurat commented Oct 28, 2022

I had problems with the setup-java input before, but I thought they were resolved. I can't confirm it since I deleted my old GitHub Actions logs.

Nevertheless, with the latest version, I can't prevent the download of JReleaser's preferred Zulu 17 JDK. I tried various combinations with
the setup-java input including empty strings ('', ""), 'false', and "false", but none of those worked.

After some googling, it appears that others have similar problems too:
actions/runner#1173
actions/runner#1483

In general, it looks like the comparison of input with boolean literal should be enclosed in parenthesis. For example, instead of

if: ${{ inputs.setup-java }} == 'true'

it should be

if: ${{ inputs.setup-java == 'true' }}

Alternatively, the parenthesis can be omitted completely, in which case GitHub Actions will add them automatically, as in

if: inputs.setup-java == 'true' (https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution)

Tnx

@aalmiray
Copy link
Member

Fixed in 2.3.1, rolled into `v2.

@dmurat
Copy link
Author

dmurat commented Oct 30, 2022

Just want to inform you that everything works now 😄
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants