Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Row size" and "Column size" in markdown-insert-table are confusing #771

Closed
umanwizard opened this issue Jun 5, 2023 · 0 comments
Closed

Comments

@umanwizard
Copy link
Contributor

markdown-insert-table prompts for number of rows with the prompt "Row size", and similarly for columns. However, I always expect "Row size" to mean the number of entries/datums in a row; i.e., its with, rather than the number of rows in the entire table.

Suggest this change:

diff -u --label /home/brennan/.emacs.d/elpa/markdown-mode-20230522.147/markdown-mode.el --label \#\<buffer\ markdown-mode.el\> /home/brennan/.emacs.d/elpa/markdown-mode-20230522.147/markdown-mode.el /tmp/buffer-content-em3a70
--- /home/brennan/.emacs.d/elpa/markdown-mode-20230522.147/markdown-mode.el
+++ #<buffer markdown-mode.el>
@@ -9736,8 +9736,8 @@
 Optional arguments ROWS, COLUMNS, and ALIGN specify number of
 rows and columns and the column alignment."
   (interactive)
-  (let* ((rows (or rows (string-to-number (read-string "Row size: "))))
-         (columns (or columns (string-to-number (read-string "Column size: "))))
+  (let* ((rows (or rows (string-to-number (read-string "Number of rows: "))))
+         (columns (or columns (string-to-number (read-string "Number of columns: "))))
          (align (or align (read-string "Alignment ([l]eft, [r]ight, [c]enter, or RET for default): ")))
          (align (cond ((equal align "l") ":--")
                       ((equal align "r") "--:")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants