Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on GFM checkboxes does not work for deeply nested list items #569

Closed
6 tasks
gabrieldeal opened this issue Dec 9, 2020 · 2 comments
Closed
6 tasks

Clicking on GFM checkboxes does not work for deeply nested list items #569

gabrieldeal opened this issue Dec 9, 2020 · 2 comments

Comments

@gabrieldeal
Copy link

Clicking on deeply nested Github Flavored Markdown checkboxes toggles the wrong checkbox.

Expected Behavior

It should toggle the checkbox I click.

Actual Behavior

For deeply nested checkboxes, it toggles an ancestor checkbox.

Steps to Reproduce

  • One
    • Two
      • Three
        • Four
          • Five (clicking this checks & unchecks Four)
            • Six (clicking this checks & unchecks Four)

Click the checkbox for Five or Six. When I do this, it toggles Four.

Backtrace

None

Software Versions

  • Markdown Mode: 2.5-dev
  • Emacs: 26.1
  • OS: Ubuntu 16 LTS
@syohex syohex mentioned this issue Dec 10, 2020
Merged
6 tasks
@gabrieldeal
Copy link
Author

Fastest bug fix ever! 🚀

I just tested your fix and it works perfectly. Thanks! @syohex

@syohex
Copy link
Collaborator

syohex commented Dec 11, 2020

Thanks for reporting issue. I have merged #570.

@syohex syohex closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syohex @gabrieldeal