-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overly aggressive fontification for within-token underscores #448
Comments
markdown-mode does not conform to all CommonMark spec. While markdown-mode conforms original markdown specification because markdown-mode was written before CommonMark birthed. I'm not sure |
I just noticed that markdown-mode also offers gfm-mode, which actually does refrain from fontification for within-token underscores, however, it also doesn't fontify within-token asterisks, which it should. I would argue that, whether or not markdown-mode strives to match CommonMark, gfm-mode should definitely strive to match GFM, as this is what it's name and documentation suggest it does. Input:In gfm-mode:
(Note the double newlines are significant.) Expected output:Lines with text "emphasis" are (at least partially) emphasized. Lines with text "no emphasis" are not emphasized at all, i.e.: emphasis emphasis emphasis emphasis emph asis emphasis no_emph_asis _no_emphasis no_emphasis_ no_em ph_asis Actual output:Only |
I have merged #495. Please check latest version. |
CommonMark specifies that, while asterisk
*
can establish within-token emphasis, underscore_
cannot.Expected Behavior
Input
should not have any emphasis, even though
emphasizes
containing
.Actual Behavior
emphasizes
containing
the same as with asterisks.Software Versions
markdown-mode version 2.4-dev (installed via MELPA)
GNU Emacs 25.2.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.21) of 2017-09-22, modified by Debian
Ubuntu 18.04.4 LTS
The text was updated successfully, but these errors were encountered: