Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

pre-inserted selectmenus-dialog-pages not removed from dom #2493

Closed
MauriceG opened this issue Sep 21, 2011 · 6 comments
Closed

pre-inserted selectmenus-dialog-pages not removed from dom #2493

MauriceG opened this issue Sep 21, 2011 · 6 comments
Assignees

Comments

@MauriceG
Copy link
Contributor

When using non-native-selectmenus, the pre-inserted dialog-page are not removed from the dom when parent page is closed.

  • visit http://jquerymobile.com/test/ with one eye on a web-inspector tool of your choice
  • click on forms elements
  • choose selectmenus
  • take a look on the created dialog-pages in the dom
  • leave the page and go again to the selectmenu-page
  • try more often

everytime the demo selectmenu-page is shown, 10 dialog-pages are added to the dom and are not removed when left.

@ghost ghost assigned jblas Sep 21, 2011
@toddparker
Copy link
Contributor

This needs to be looked at, thanks for submitting.

@ghost ghost assigned johnbender Sep 21, 2011
@MauriceG
Copy link
Contributor Author

it seems, today is "clear-up-day" ... i'm sorry to mess it up ;-) ...

@toddparker
Copy link
Contributor

We appreciate the help finding bugs, even if it's more work for us.

@MauriceG
Copy link
Contributor Author

@toddparker

And i appreciate your work. You make really cool things working...

Allow me some short words about selectmenus:
To use long non-native selects is always a fight with the occurring page events if they used at the parent...
And, as it seems, they are a problem with the dom management too.
Excuse me if i talk about iOS now, but the native select on ipad shows a nice to use
scrollable canvas and not a full screen-page, if the selectlist is long.
A long option-list is most often not a wide one. And if, just the font-size is scaled down.
Why the team not just make the small-non-native-select to a long, scrollable select,
if more options inside than educible
And, this would be the icing on the cake and would hit the iOS select, an integrated, switchable search on the top.

@toddparker
Copy link
Contributor

I think we're going to take a fresh look at custom selects post-1.0. The work needed to generate a custom select menu, especially a long one causes performance to be pretty sluggish which is why we've been pushing people to use the native menus for the near term. On iPad, the native menu will show up as a popover which is pretty much what you're asking for, except without the search or theming, in a native control. Once devices get a bit faster and overflow: support improves, we'll be able to do some cool stuff.

@johnbender
Copy link
Contributor

After some serious work/testing/thought this one should be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants