Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe envify should be a dependency? #308

Closed
jonasfj opened this issue Feb 1, 2016 · 2 comments
Closed

Maybe envify should be a dependency? #308

jonasfj opened this issue Feb 1, 2016 · 2 comments

Comments

@jonasfj
Copy link

jonasfj commented Feb 1, 2016

I'm using this in a browserify project:
https://github.com/taskcluster/taskcluster-tools

Currently upgrading and finding that:

  "browserify": {
    "transform": [
      "envify"
    ]
  }

causes me browserify to want to run envify when I include this in my project. Is that intended?

@jquense
Copy link
Owner

jquense commented Feb 1, 2016

yes per: #271. Though it does look like it should be including envify as a real dependency and not a devDep, which is (I am assuming) why its erroring out on you.

@jonasfj
Copy link
Author

jonasfj commented Feb 1, 2016

Yeah, making envify a dependency in my project solved it...

But since you have "main": "lib/index.js", which is already compiled with babel/browserify.
Okay, I'm no browserify expert..

Making envify a dependency would certainly work fine :)

@jonasfj jonasfj changed the title envify intended to be required downstream? Maybe envify should be a dependency? Feb 1, 2016
@jquense jquense closed this as completed in 665549d Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants